PYTHON-4815 Migrate test_discovery_and_monitoring.py to async #1893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahStapp
requested changes
Oct 3, 2024
| # Update max cluster time even when hello fails. | ||
| details = cast(Mapping[str, Any], exc.details) | ||
| self._topology.receive_cluster_time(details.get("$clusterTime")) | ||
| await self._topology.receive_cluster_time(details.get("$clusterTime")) |
| _IS_SYNC = False | ||
|
|
||
| # Location of JSON test specifications. | ||
| SDAM_PATH = os.path.join(os.path.dirname(os.path.realpath(__file__)), "discovery_and_monitoring") |
There was a problem hiding this comment.
This needs to be updated to point to test/discovery_and_monitoring instead of test/asynchronous/discovery_and_monitoring.
| else: | ||
| raise AssertionError(f"Unknown when field {when}") | ||
|
|
||
| topology.handle_error( |
| description = phase.get("description", str(i)) | ||
| with assertion_context(f"phase: {description}"): | ||
| for response in phase.get("responses", []): | ||
| got_hello(c, common.partition_node(response[0]), response[1]) |
|
@sleepyStick should this be closed in favor of #2093? |
yeah, I was gonna close it once #2093 was merged haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.